Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Add Payment Methods index component #5530

Merged

Conversation

rainerdema
Copy link
Contributor

@rainerdema rainerdema commented Nov 30, 2023

Summary

Screenshot 2023-12-01 at 11 42 23

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@rainerdema rainerdema self-assigned this Nov 30, 2023
@rainerdema rainerdema changed the title [Admin] Add Payment Methods index component #5526 [Admin] Add Payment Methods index component Nov 30, 2023
@github-actions github-actions bot added changelog:solidus_core Changes to the solidus_core gem changelog:solidus_admin labels Nov 30, 2023
@rainerdema rainerdema force-pushed the rainerd/admin/payment-methods-index-page branch 2 times, most recently from 417357b to 77901ff Compare November 30, 2023 13:31
Introduced a fix to conditionally enable the sortable functionality in 
the `ui/table` component.

This enhancement activates sorting options only when the default scope
is applied, which is assumed to align with `Model.all`.

This approach is taken as a precautionary measure to prevent issues in 
data
positioning and sorting when other, more complex scopes are applied.
@rainerdema rainerdema force-pushed the rainerd/admin/payment-methods-index-page branch from 77901ff to 7d24bf4 Compare December 1, 2023 10:44
Enhanced the search capabilities in the admin panel by updating
the `allowed_ransackable_attributes` of the `Spree::PaymentMethod` 
model.

This update specifically adds the `name` and `description` fields to the
list of attributes that can be searched using Ransack.
@rainerdema rainerdema force-pushed the rainerd/admin/payment-methods-index-page branch from 7d24bf4 to 5d09a12 Compare December 1, 2023 10:50
@rainerdema rainerdema force-pushed the rainerd/admin/payment-methods-index-page branch from 5d09a12 to dc968c6 Compare December 1, 2023 10:52
@rainerdema rainerdema marked this pull request as ready for review December 1, 2023 10:53
@rainerdema rainerdema requested a review from a team as a code owner December 1, 2023 10:53
@rainerdema rainerdema requested review from elia and a team and removed request for a team December 1, 2023 10:53
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rainerdema rainerdema merged commit 81b8be6 into solidusio:main Dec 1, 2023
8 checks passed
@rainerdema rainerdema deleted the rainerd/admin/payment-methods-index-page branch December 1, 2023 11:37
@elia elia removed the changelog:solidus_core Changes to the solidus_core gem label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants