Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a TaxRate#display_amount and a tax categories & rates admin index #5529

Merged
merged 10 commits into from
Nov 30, 2023
Merged

Add a TaxRate#display_amount and a tax categories & rates admin index #5529

merged 10 commits into from
Nov 30, 2023

Conversation

elia
Copy link
Member

@elia elia commented Nov 29, 2023

Summary

Replaces #5520

image image

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Nov 29, 2023
@elia elia requested a review from a team as a code owner November 29, 2023 18:05
@github-actions github-actions bot added changelog:solidus_core Changes to the solidus_core gem changelog:solidus_admin labels Nov 29, 2023
@elia elia mentioned this pull request Nov 29, 2023
Closed
3 tasks
@elia elia requested a review from rainerdema November 29, 2023 18:06
rainerdema
rainerdema approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! 🌟

@elia elia merged commit 0137397 into main Nov 30, 2023
8 checks passed
@elia elia deleted the elia/admin/tax-rates/index branch November 30, 2023 09:26
@elia elia changed the title [admin] Add a tax categories & rates index Add a TaxRate#display_amount and a tax categories & rates admin index Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainerdema rainerdema rainerdema approved these changes

Assignees

@elia elia

Labels
changelog:solidus_admin changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elia @rainerdema