Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[admin] Add a promotions/index component #5517

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[admin] Add a promotions/index component #5517

merged 1 commit into from
Nov 28, 2023

Conversation

elia
Copy link
Member

@elia elia commented Nov 24, 2023 •
edited
Loading

Summary

image

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Nov 24, 2023
@github-actions github-actions bot added changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_admin labels Nov 24, 2023
@github-actions github-actions bot removed the changelog:solidus_backend Changes to the solidus_backend gem label Nov 27, 2023
@elia elia force-pushed the elia/admin/promotions branch 7 times, most recently from e8e9ab7 to ebbf37b Compare November 27, 2023 16:59
@elia elia requested a review from rainerdema November 27, 2023 17:17
@elia elia marked this pull request as ready for review November 27, 2023 17:17
@elia elia requested a review from a team as a code owner November 27, 2023 17:17
rainerdema
rainerdema approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elia elia merged commit c74eafa into main Nov 28, 2023
8 checks passed
@elia elia deleted the elia/admin/promotions branch November 28, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainerdema rainerdema rainerdema approved these changes

Assignees

@elia elia

Labels
changelog:solidus_admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elia @rainerdema