set_position conflicts with acts_as_list

[tkimi]

Summary

Fixes #5508

Remove set_position callback

I thought about changing the test as in this diff, but decided to just remove it since this is just testing acts_as_list.

diff --git a/core/spec/models/spree/variant_spec.rb b/core/spec/models/spree/variant_spec.rb
index 84cab17c1f..7246a74e60 100644
--- a/core/spec/models/spree/variant_spec.rb
+++ b/core/spec/models/spree/variant_spec.rb
@@ -574,11 +574,13 @@ RSpec.describe Spree::Variant, type: :model do
     end
   end
 
-  # Regression test for https://github.com/spree/spree/issues/2744
-  describe "set_position" do
-    it "sets variant position after creation" do
-      variant = create(:variant)
-      expect(variant.position).to_not be_nil
+  describe "acts_as_list" do
+    it "sets variant position by acts_as_list" do
+      expect(variant.product.master.position).to eq 1
+      expect(variant.position).to eq 2
+
+      multi_variant = create(:variant, product: variant.product)
+      expect(multi_variant.position).to eq 3
     end
   end

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have used clear, explanatory commit messages.

The following are not always needed:

• 📖 I have updated the README to account for my changes.
• 📑 I have documented new code with YARD.
• 🛣️ I have opened a PR to update the guides.
• ✅ I have added automated tests to cover my changes.
• 📸 I have attached screenshots to demo visual changes.

[jarednorman]

Do we really want to remove this test? We still want to persist this behaviour, even if we're removing the callback, right?

[tkimi]

I wonder if I should write a test for "acts as list" only for Variant, but we feel safer with a spec.
So I added this test! 77aceb0

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (378ed49) 88.65% compared to head (77aceb0) 88.65%.
Report is 13 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5509      +/-   ##
==========================================
- Coverage   88.65%   88.65%   -0.01%     
==========================================
  Files         627      627              
  Lines       15037    15034       -3     
==========================================
- Hits        13331    13328       -3     
  Misses       1706     1706              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.