Update the spree.rb.tt stripe configuration instructions for SolidusStripe v5+
#5505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5505 +/- ##
==========================================
+ Coverage 88.46% 88.93% +0.47%
==========================================
Files 633 622 -11
Lines 15160 14918 -242
==========================================
- Hits 13411 13268 -143
+ Misses 1749 1650 -99 ☔ View full report in Codecov by Sentry. |
jarednorman
approved these changes
Nov 13, 2023
kennyadsl
reviewed
Nov 20, 2023
core/lib/generators/solidus/install/templates/config/initializers/spree.rb.tt
Outdated
Show resolved
Hide resolved
Specify they're for version >= 5. Co-Authored-By: Alberto Vena <[email protected]>
elia
force-pushed
the
modify-spree-rb-tt-solidus-stripe-instructions
branch
from
2565851
to
00df613
Compare
jarednorman
approved these changes
Dec 18, 2023
elia
changed the title
elia
changed the title
spree.rb.tt stripe configuration instructions for SolidusStripe v5+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Spree::PaymentMethod::StripeCreditCard is no longer available when using solidus_stripe 5.0 and above as the Spree folder was removed.
This instruction can therefore be misleading for future solidus / solidus_stripe installs.