Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Allow editing the order contact email #5500

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Conversation

elia
Copy link
Member

@elia elia commented Nov 3, 2023

Summary

click edit submit
image image image

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Nov 3, 2023
@elia elia force-pushed the elia/admin/orders-customer branch 3 times, most recently from 9decc64 to e446a13 Compare November 6, 2023 09:17
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #5500 (5b25f50) into main (eab114b) will increase coverage by 0.01%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##             main    #5500      +/-   ##
==========================================
+ Coverage   88.93%   88.95%   +0.01%     
==========================================
  Files         622      624       +2     
  Lines       14918    14945      +27     
==========================================
+ Hits        13268    13294      +26     
- Misses       1650     1651       +1     
Files Coverage Δ
.../components/solidus_admin/orders/show/component.rb 100.00% <ø> (ø)
...nents/solidus_admin/orders/show/email/component.rb 100.00% <100.00%> (ø)
.../controllers/solidus_admin/customers_controller.rb 100.00% <100.00%> (ø)
...app/controllers/solidus_admin/orders_controller.rb 97.14% <90.90%> (-2.86%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@elia elia force-pushed the elia/admin/orders-customer branch 3 times, most recently from 19f4bea to 3e89efa Compare November 7, 2023 10:50
@elia elia marked this pull request as ready for review November 7, 2023 12:07
@elia elia requested a review from a team as a code owner November 7, 2023 12:07
@elia elia requested review from rainerdema and removed request for a team November 7, 2023 12:07
@tvdeyen
Copy link
Member

tvdeyen commented Nov 7, 2023

the dialog title and controller name suggest that we update the user of the order (customer) but it only allows to change the email. are there any plans to add customer select as well or should we rename the controller and title to reflect that only the email gets changed?

@elia elia force-pushed the elia/admin/orders-customer branch from 3e89efa to 8875493 Compare November 7, 2023 15:12
@elia elia force-pushed the elia/admin/orders-customer branch from 8875493 to 1677f24 Compare November 7, 2023 16:42
This way the natively show as inline.
@elia
Copy link
Member Author

elia commented Nov 7, 2023

the dialog title and controller name suggest that we update the user of the order (customer) but it only allows to change the email. are there any plans to add customer select as well or should we rename the controller and title to reflect that only the email gets changed?

Fixed, good catch 👍

image

@elia elia merged commit e7217a9 into main Nov 7, 2023
10 checks passed
@elia elia deleted the elia/admin/orders-customer branch November 7, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants