Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup use of raise_error #548

Merged
merged 4 commits into from
Dec 7, 2015
Merged

Cleanup use of raise_error #548

merged 4 commits into from
Dec 7, 2015

Conversation

jhawthorn
Copy link
Contributor

  • Removed cases of expect{ ... }.not_to raise_error, which does nothing, as errors already cause failures.
  • Always assert for a message when we're rescuing from RuntimeError
  • Use have_no_css instead of checking for ElementNotFound exception in one test

@jhawthorn jhawthorn changed the title Cleanup use of raise_error Cleanup use of raise_error Nov 26, 2015
@jhawthorn
Be specific when testing for RuntimeError
94ecd24 
RuntimeError could be one of many errors, so we should use a regex to
ensure we receive the correct message.
@jhawthorn
Remove unnecessary test
358656d 
This test has no assertions and is covered by the next test.
@stewart
Copy link
Contributor

stewart commented Nov 27, 2015

👍 for ✂️

@cbrunsdon
Copy link
Contributor

Yep, good by me too, thx hawth 👍

@athal7
Copy link
Contributor

athal7 commented Dec 7, 2015

👍

athal7 pushed a commit that referenced this pull request Dec 7, 2015
Merge pull request #548 from jhawthorn/raise_error_cleanup
372d4b3 
Cleanup use of raise_error
@athal7 athal7 merged commit 372d4b3 into solidusio:master Dec 7, 2015
@jhawthorn jhawthorn deleted the raise_error_cleanup branch October 17, 2016 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhawthorn @stewart @cbrunsdon @athal7