SolidusAdmin customer picker for order #5462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
force-pushed
the
elia/admin/customer-picker
branch
2 times, most recently
from
848bff8
to
88ce971
Compare
elia
force-pushed
the
elia/admin/customer-picker
branch
from
88ce971
to
9019ea6
Compare
elia
force-pushed
the
elia/admin/customer-picker
branch
2 times, most recently
from
9181973
to
3085cf7
Compare
Codecov Report
@@ Coverage Diff @@
## main #5462 +/- ##
==========================================
- Coverage 88.65% 88.58% -0.07%
==========================================
Files 627 629 +2
Lines 15037 15061 +24
==========================================
+ Hits 13331 13342 +11
- Misses 1706 1719 +13
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
The search component becomes more adaptable this way and can be placed in more ways within or without a panel. The panel component gained an `actions` slot and updated paddings, removing the need for the previously used negative margins.
The button that we used initially was to high.
Also make the header and footer sticky.
elia
force-pushed
the
elia/admin/customer-picker
branch
from
3085cf7
to
e94d8d5
Compare
elia
force-pushed
the
elia/admin/customer-picker
branch
from
e94d8d5
to
2c52166
Compare
Remove the title so that "Customer" will only refer to Spree::User.
elia
force-pushed
the
elia/admin/customer-picker
branch
from
2c52166
to
de59f4a
Compare
rainerdema
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
for reviewers: most of the initial commits are one-liners, so don't get scared
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: