Minimum Quantity promotion rule #5452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure why this padding was ever added, but it made the actions not line up next to the rules which was silly.
github-actions
bot
added
changelog:solidus_backend
jarednorman
approved these changes
Oct 24, 2023
mamhoff
added a commit
to friendlycart/solidus_friendly_promotions
that referenced
this pull request
Oct 27, 2023
Original PR: solidusio/solidus#5452 This new rule allows for an easy way of providing "bulk" discounts through the promotion system. It will prevent a promotion from being applied until it meets a quantity threshold. The rule will also account for other rules that limit the applicable line items. (e.g.: Taxons, options values, etc.) Co-authored-by: Benjamin Wil <[email protected]> Co-authored-by: Adam Mueller <[email protected]>
|
@adammathys thanks. There seems to be related spec failures and the i18n task also complains. Mind to take another look? |
adammathys
force-pushed
the
minimum-quantity-promotion-rule
branch
from
220459a
to
a0d153f
Compare
|
@tvdeyen Oops! 🤦🏻♂️ Was still using some custom factories, swapped in the default ones so it should be good to go now. |
Codecov Report
@@ Coverage Diff @@
## main #5452 +/- ##
==========================================
+ Coverage 88.91% 88.92% +0.01%
==========================================
Files 614 615 +1
Lines 14830 14844 +14
==========================================
+ Hits 13186 13200 +14
Misses 1644 1644
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jarednorman
approved these changes
Oct 30, 2023
tvdeyen
approved these changes
Nov 1, 2023
This new rule allows for an easy way of providing "bulk" discounts through the promotion system. It will prevent a promotion from being applied until it meets a quantity threshold. The rule will also account for other rules that limit the applicable line items. (e.g.: Taxons, options values, etc.) Co-authored-by: Benjamin Wil <[email protected]>
adammathys
force-pushed
the
minimum-quantity-promotion-rule
branch
from
a0d153f
to
cb4692e
Compare
mamhoff
added a commit
to friendlycart/solidus_friendly_promotions
that referenced
this pull request
Jul 1, 2024
Original PR: solidusio/solidus#5452 This new rule allows for an easy way of providing "bulk" discounts through the promotion system. It will prevent a promotion from being applied until it meets a quantity threshold. The rule will also account for other rules that limit the applicable line items. (e.g.: Taxons, options values, etc.) Co-authored-by: Benjamin Wil <[email protected]> Co-authored-by: Adam Mueller <[email protected]>
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Jul 1, 2024
Original PR: solidusio#5452 This new rule allows for an easy way of providing "bulk" discounts through the promotion system. It will prevent a promotion from being applied until it meets a quantity threshold. The rule will also account for other rules that limit the applicable line items. (e.g.: Taxons, options values, etc.) Co-authored-by: Benjamin Wil <[email protected]> Co-authored-by: Adam Mueller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a new promotion rule for minimum quantity. This rule will prevent a promotion from applying until a specified quantity threshold is met. It also hooks into
PromotionRule#actionable?on other rules to ensure the quantity considered is only for relevant line items.This promotion rule is helpful for creating "bulk discount" type promotions where you want to offer a discount when a customer orders at least a certain amount of items. Such a promotion is not quite possible with the current rules and actions. (You can sort of come close with the
CreateQuantityAdjustmentsaction, but that promotion won't stack properly.)Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: