SolidusAdmin misc. component fixes #5444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
force-pushed
the
elia/admin/misc-fixes
branch
from
6c8019b
to
9e13528
Compare
Codecov Report
@@ Coverage Diff @@
## main #5444 +/- ##
=======================================
Coverage 88.89% 88.89%
=======================================
Files 612 612
Lines 14800 14800
=======================================
Hits 13156 13156
Misses 1644 1644
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rainerdema
approved these changes
Oct 19, 2023
admin/app/components/solidus_admin/ui/forms/switch/component.rb
Outdated
Show resolved
Hide resolved
Also adds a focus-ring, which was missing.
This slightly reduces the computational and memory needs for rendering a button.
It was just a placeholder.
Those are already set by TW for each font size and we want to adhere to the standard rather than setting our owns.
Sometimes the render method is not available at the component initialization.
elia
force-pushed
the
elia/admin/misc-fixes
branch
from
9e13528
to
5576314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A number of smaller fixes that I don't expect to require separate PRs.
See the commit list for details.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: