Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Enhance toast component: Background color and animations #5442

Merged
merged 5 commits into from
Oct 20, 2023
Merged

[Admin] Enhance toast component: Background color and animations #5442

merged 5 commits into from
Oct 20, 2023

Conversation

rainerdema
Copy link
Contributor

@rainerdema rainerdema commented Oct 17, 2023 •
edited

Summary

This PR brings two enhancements to the toast UI component:

  1. Updated the default background from bg-gray-800 to bg-full-black for better visibility.
  2. Added smooth slide-in and fade-out animations for a better UX when the toast is displayed or dismissed.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@rainerdema rainerdema requested a review from elia October 17, 2023 16:02
@rainerdema rainerdema self-assigned this Oct 17, 2023
@rainerdema rainerdema marked this pull request as ready for review October 17, 2023 16:11
@rainerdema rainerdema requested a review from a team as a code owner October 17, 2023 16:11
@rainerdema
Update toast default background to black
7959b2d 
Changed the default background color of the toast component
to black for improved visibility and contrast.
@rainerdema rainerdema force-pushed the rainerd/admin/toast-improvements branch from 98b39c2 to f1545ae Compare October 19, 2023 07:44
@rainerdema rainerdema force-pushed the rainerd/admin/toast-improvements branch from f1545ae to 35a6973 Compare October 19, 2023 08:03
@rainerdema
Center-align text in toast component
1be70fd
@rainerdema
Add in and out animations to toast
d2ba3e7 
Implemented slide-in and fade-out animations for the toast
component to enhance user experience when the toast appears
or disappears.
@rainerdema rainerdema force-pushed the rainerd/admin/toast-improvements branch from 35a6973 to d2ba3e7 Compare October 19, 2023 08:11
@rainerdema
Convert camelCase to kebab-case for color names in tailwind configura…
788d7f0 
…tion

This commit transitions the naming convention for our custom Tailwind color
classes from camelCase to kebab-case.
This shift aligns our custom classes with the standard Tailwind CSS naming
convention, ensuring consistency and clarity.
mfrecchiami
mfrecchiami approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@mfrecchiami mfrecchiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @rainerdema 🚀

@rainerdema rainerdema merged commit b4690fb into solidusio:main Oct 20, 2023
9 checks passed
@rainerdema rainerdema deleted the rainerd/admin/toast-improvements branch October 20, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrecchiami mfrecchiami mfrecchiami approved these changes

@elia elia elia approved these changes

Assignees

@rainerdema rainerdema

Labels
changelog:solidus_admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rainerdema @elia @mfrecchiami