Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Enhance toast message positioning and layering #5436

Merged
merged 2 commits into from
Oct 13, 2023
Merged

[Admin] Enhance toast message positioning and layering #5436

merged 2 commits into from
Oct 13, 2023

Conversation

rainerdema
Copy link
Contributor

Summary

Before
Screenshot 2023-10-13 at 13 29 23

Now
Screenshot 2023-10-13 at 13 28 29

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@rainerdema
Center toast message horizontally for improved visibility
4657462
@rainerdema
Reposition toast for improved layering
dfd7d3b 
Adjust toast location to enhance visual order, preventing unintentional overlay.
@rainerdema rainerdema requested a review from elia October 13, 2023 11:44
@rainerdema rainerdema requested a review from a team as a code owner October 13, 2023 11:44
@rainerdema rainerdema self-assigned this Oct 13, 2023
@rainerdema rainerdema merged commit 3c74c9a into solidusio:main Oct 13, 2023
7 checks passed
@rainerdema rainerdema deleted the rainerd/admin/move-admin-application-toast branch October 13, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elia elia elia approved these changes

Assignees

@rainerdema rainerdema

Labels
changelog:solidus_admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rainerdema @elia