[Admin] Construct base components for order creation in admin interface #5434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainerdema
force-pushed
the
rainerd/base-order-creation-components
branch
3 times, most recently
from
4b4579d
to
1ede2a5
Compare
rainerdema
commented
Oct 12, 2023
elia
reviewed
Oct 13, 2023
| def new | ||
| @order = Spree::Order.new( | ||
| { | ||
| created_by_id: spree_current_user.try(:id), |
There was a problem hiding this comment.
spree_current_user comes from one of many possible authentication methods, here it's better to use the internal method for getting the admin user. Also no nil checks are needed as from we no longer support not having an authenticated user in the admin.
created_by: current_solidus_admin_user
admin/spec/components/solidus_admin/orders/new/component_spec.rb
Outdated
Show resolved
Hide resolved
rainerdema
force-pushed
the
rainerd/base-order-creation-components
branch
from
1ede2a5
to
2b8360a
Compare
elia
reviewed
Oct 13, 2023
Comment on lines
23
to
27
| { | ||
| created_by: current_solidus_admin_user, | ||
| frontend_viewable: false, | ||
| store_id: current_store.try(:id) | ||
| } |
There was a problem hiding this comment.
nit: don't need to wrap in curly braces, I would even expected rubocop to complain about this 🤷♂️
There was a problem hiding this comment.
Good catch! You're right, it's a copy-paste leftover from the old backend orders controller 😅 Will clean that up, thanks!
elia
approved these changes
Oct 13, 2023
This commit introduces a new `orders/new` component that includes a header, providing users with 'Save' and 'Discard' button options. Although the UI elements have been integrated, the functionalities for these buttons will be implemented in subsequent iterations.
rainerdema
force-pushed
the
rainerd/base-order-creation-components
branch
from
2b8360a
to
b8f3a4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR lays the foundation for the
orders/newcomponent and integrates basic UI elements withinsolidus_admin.orders/newcomponentSaveandDiscardbuttonsChecklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: