Extract a products/stock component
#5433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
force-pushed
the
elia/admin/product-components
branch
2 times, most recently
from
8a3dd41
to
a4b6bf2
Compare
elia
force-pushed
the
elia/admin/product-components
branch
from
a4b6bf2
to
595b072
Compare
Codecov Report
@@ Coverage Diff @@
## main #5433 +/- ##
==========================================
+ Coverage 88.86% 88.88% +0.01%
==========================================
Files 610 611 +1
Lines 14793 14799 +6
==========================================
+ Hits 13146 13154 +8
+ Misses 1647 1645 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rainerdema
approved these changes
Oct 13, 2023
Comment on lines
+4
to
+9
| def self.from_product(product) | ||
| new( | ||
| on_hand: product.total_on_hand, | ||
| variants_count: product.variants.count, | ||
| ) | ||
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Both the stock and status component now accept basic values in the initializer and have an alternative
from_productconstructor that will get those basic values from a Spree::Product object.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: