Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Ensure labels are clickable by parameterizing ids #5429

Merged
merged 1 commit into from
Oct 11, 2023
Merged

[Admin] Ensure labels are clickable by parameterizing ids #5429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Resolve issue with clickable labels due to spaces in IDs 
Ensure that IDs generated for labels do not contain spaces, utilizing the
`parameterize` method.

This resolves an issue where labels were not clickable due to invalid characters
in corresponding IDs.
  • Loading branch information
@rainerdema
rainerdema committed Oct 10, 2023
commit 5b24d714c4f0aadfbc7277fe4652e815d4c09a21
2 changes: 1 addition & 1 deletion admin/app/components/solidus_admin/ui/table/ransack_filter/component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def initialize(
def before_render
@selections = @options.map.with_index do |(label, value), opt_index|
Selection.new(
"#{stimulus_id}--#{label}-#{value}",
"#{stimulus_id}--#{label}-#{value}".parameterize,
label,
build(:attribute, @attribute, opt_index),
build(:predicate, @predicate, opt_index),
Expand Down