Add dependent: :destroy to Spree::Order#order_promotions
#5411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
mamhoff
force-pushed
the
destroy-dependent-order-promotions
branch
2 times, most recently
from
869ecd2
to
885a62d
Compare
Codecov Report
@@ Coverage Diff @@
## main #5411 +/- ##
=======================================
Coverage 88.96% 88.96%
=======================================
Files 617 617
Lines 14876 14876
=======================================
Hits 13235 13235
Misses 1641 1641
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
adammathys
approved these changes
Oct 3, 2023
mamhoff
added a commit
to friendlycart/solidus_friendly_promotions
that referenced
this pull request
Oct 4, 2023
This is the same change as in solidusio/solidus#5411
|
Should I provide a migration to clear out orphaned records and add a foreign key constraint as well? |
We found a lot of orphaned records in our database due to this missing dependent: :destroy.
mamhoff
force-pushed
the
destroy-dependent-order-promotions
branch
from
885a62d
to
b202ce7
Compare
|
Rebased, added foreign key constraint. |
|
@mamhoff can we ask for a ? thanks |
tvdeyen
approved these changes
Oct 27, 2023
This adds a foreign key constraint that makes sure at the database level that we don't have non-existent order IDs in the spree_orders_promotions table.
mamhoff
force-pushed
the
destroy-dependent-order-promotions
branch
from
b202ce7
to
9e4a2c9
Compare
|
Done |
elia
changed the title
dependent: :destroy to Spree::Order#order_promotions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We found a lot of orphaned records in our database due to this missing dependent: :destroy.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: