Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the link to customization guides #5404

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Fix the link to customization guides #5404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ The storefront will be accessible at
[http:https://localhost:3000/](http:https://localhost:3000/) and the admin can be found at
[http:https://localhost:3000/admin/](http:https://localhost:3000/admin/).

For information on how to customize your store, check out the [customization guides](https://guides.solidus.io/developers/customizations/overview.html).
For information on how to customize your store, check out the [customization guides](https://guides.solidus.io/customization/customizing-your-storefront).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pokonski, thanks for catching this!

I noticed there's also this link that unfortunately leads to a 404:

https://github.com/solidusio/solidus/blob/51f44e13c0ee967645f54a4a074ea262988c8a40/bin/sandbox#L104C4-L104C80

🚀 https://guides.solidus.io/developers/getting-started/first-time-installation

instead of

🚀 https://guides.solidus.io/getting-started/installing-solidus

If you could add this fix as well, that'd be awesome!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably makes sense to also add those to the guides redirects https://github.com/solidusio/edgeguides/blob/9bf18e4910f5124075dcd3041ce7368714f879ab/docusaurus.config.js#L178-L186

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @elia! Here's the PR link: solidusio/edgeguides#126


### Default Username/Password

Expand Down
2 changes: 1 addition & 1 deletion bin/sandbox
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,4 +101,4 @@ unbundled bin/rails generate solidus:install --admin-preview --auto-accept $@
echo "
🚀 This app is intended for test purposes. If you're interested in running
🚀 Solidus in production, visit:
🚀 https://guides.solidus.io/developers/getting-started/first-time-installation"
🚀 https://guides.solidus.io/getting-started/installing-solidus"