[Admin] Ensure action_name is passed as symbol for cancancan authorization
#5399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_core
rainerdema
force-pushed
the
rainerd/fix/cancancan-action-name-symbol
branch
from
c2faa57
to
ae16e5a
Compare
github-actions
bot
removed
changelog:solidus_core
rainerdema
changed the title
cancancan authorizationaction_name is passed as symbol for cancancan authorization
rainerdema
force-pushed
the
rainerd/fix/cancancan-action-name-symbol
branch
3 times, most recently
from
14f9f83
to
aa0a406
Compare
elia
reviewed
Oct 2, 2023
admin/app/controllers/solidus_admin/controller_helpers/authorization.rb
Outdated
Show resolved
Hide resolved
rainerdema
force-pushed
the
rainerd/fix/cancancan-action-name-symbol
branch
from
aa0a406
to
b06342d
Compare
elia
approved these changes
Oct 4, 2023
Comment on lines
1
to
2
| <h1><%= t('solidus_admin.errors.authorization.access_denied.title') %></h1> | ||
| <p><%= t('solidus_admin.errors.authorization.access_denied.description') %></p> |
There was a problem hiding this comment.
Thoughts on adding some TW style to this so it fits in with the context?
There was a problem hiding this comment.
Great point! I've added some TW styling for padding and alignment to ensure it meshes well with the context:
Let me know WDYT 🙌
rainerdema
force-pushed
the
rainerd/fix/cancancan-action-name-symbol
branch
from
b06342d
to
c155a5f
Compare
Fix CanCanCan authorization by converting action_name to symbol. In the context of implementing permissions in the Solidus Demo, we identified that `action_name` in string format doesn't align with CanCanCan's `authorize!` method expectations. It needs to be in symbol format to be processed correctly. This change ensures our authorization logic functions as intended also for the new solidus admin views.
Enhance the SolidusAdmin authorization mechanism to improve user experience during unauthorized access attempts. Now, instead of previous behavior, users are redirected to a dedicated unauthorized page when attempting to access a resource for which they do not have permission.
rainerdema
force-pushed
the
rainerd/fix/cancancan-action-name-symbol
branch
from
c155a5f
to
dca1907
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the context of implementing permissions in the Solidus Demo, we identified that
action_namein string format doesn't align with CanCanCan'sauthorize!method expectations.It needs to be in symbol format to be processed correctly.
This change ensures our authorization logic functions as intended even for the new solidus admin views.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: