[Admin] Enhance ui/table component with clickable rows and URL navigation
#5397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainerdema
commented
Sep 29, 2023
rainerdema
force-pushed
the
rainerd/fix/ui-table-row-click-bug
branch
from
1fa447c
to
6a92414
Compare
rainerdema
commented
Sep 29, 2023
rainerdema
force-pushed
the
rainerd/fix/ui-table-row-click-bug
branch
from
6a92414
to
78e51c2
Compare
rainerdema
force-pushed
the
rainerd/fix/ui-table-row-click-bug
branch
from
78e51c2
to
7086186
Compare
rainerdema
commented
Oct 10, 2023
rainerdema
force-pushed
the
rainerd/fix/ui-table-row-click-bug
branch
from
7086186
to
97b8982
Compare
rainerdema
changed the title
ui/table component rows should accept clicks on the whole lineui/table component with clickable rows and URL navigation
rainerdema
force-pushed
the
rainerd/fix/ui-table-row-click-bug
branch
from
97b8982
to
35c76d3
Compare
elia
reviewed
Oct 12, 2023
Previously, the ui/table component would not register clicks on the whole line due to nested anchor elements within the table data cells. This commit fixes the click behavior to ensure the entire row is clickable.
This commit introduces the capability of navigational rows within
the `ui/table` component through the addition of a `row_url` proc.
The `fade_row_proc` parameter is renamed to `row_fade` to maintain a consistent
naming style throughout the component.
The `row_url` proc accepts a row object as a parameter and returns a URL string.
This URL is utilized to redirect the user when a particular row is clicked.
However, this navigation is deliberately disabled in "batch" mode to maintain the
row selection in that mode.
Example of usage:
```ruby
row_url: ->(order) { spree.edit_admin_order_path(order) }
```
rainerdema
force-pushed
the
rainerd/fix/ui-table-row-click-bug
branch
from
35c76d3
to
00cb97a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the
ui/tablecomponent would not register clicks on the whole line due to nested anchor elements within the table data cells.ui/tablecomponent is clickable.row_urlproc to dynamically allocate URLs to rows.Admin.Enhance.ui.table.component.with.clickable.rows.and.URL.navigation.mov
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: