Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Add missing items to the main navigation #5260

Merged
merged 1 commit into from
Jul 20, 2023
Merged

[Admin] Add missing items to the main navigation #5260

merged 1 commit into from
Jul 20, 2023

Conversation

waiting-for-dev
Copy link
Contributor

@waiting-for-dev waiting-for-dev commented Jul 20, 2023 •
edited
Loading

Summary

This commit adds the missing items to the admin main navigation to bring it to parity with the old UI. We also update the option types label to keep using the old name, so there's no mismatch when changing UIs.

screenshot-localhost_3000-2023 07 20-10_02_31

Ref. #5106

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@waiting-for-dev
Add missing items to the admin main navigation
a35c609 
This commit adds the missing items to the admin main navigation to bring
it to parity with the old UI. We also update the option types label to
keep using the old name, so there's no mismatch when changing UIs.
@waiting-for-dev waiting-for-dev requested a review from a team as a code owner July 20, 2023 08:03
@waiting-for-dev waiting-for-dev self-assigned this Jul 20, 2023
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Jul 20, 2023
@waiting-for-dev waiting-for-dev added the type:enhancement Proposed or newly added feature label Jul 20, 2023
kennyadsl
kennyadsl approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@waiting-for-dev waiting-for-dev merged commit 34d95a0 into solidusio:nebulab/admin Jul 20, 2023
3 checks passed
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/admin/main_nav_missing_links branch July 20, 2023 08:08
@elia elia added changelog:solidus_admin and removed changelog:repository Changes to the repository not within any gem labels Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elia elia elia approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

@rainerdema rainerdema Awaiting requested review from rainerdema

Assignees

@waiting-for-dev waiting-for-dev

Labels
changelog:solidus_admin type:enhancement Proposed or newly added feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waiting-for-dev @elia @kennyadsl