Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove solidus_frontend option from the installer #5047

Conversation

waiting-for-dev
Copy link
Contributor

Summary

From #5045 (closed by error)

The classic frontend is deprecated and no longer part of the meta-gem (see #5026).

Closes #5027

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

The classic frontend is deprecated and no longer part of the meta-gem
(see #5026).

Closes #5027
@waiting-for-dev waiting-for-dev requested a review from a team as a code owner April 26, 2023 09:50
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Apr 26, 2023
@waiting-for-dev waiting-for-dev self-assigned this Apr 26, 2023
@waiting-for-dev waiting-for-dev added the type:enhancement Proposed or newly added feature label Apr 26, 2023
@waiting-for-dev
Copy link
Contributor Author

Merging, as it was already approved in #5045

@waiting-for-dev waiting-for-dev merged commit 3ee976d into master Apr 26, 2023
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/remove_solidus_frontend_from_the_installer branch April 26, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem type:enhancement Proposed or newly added feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate removing the classic frontend as an option for the installer
1 participant