Remove Deprecated code from Backend component #5021
Conversation
kennyadsl
added
type:enhancement
github-actions
bot
added
the
changelog:solidus_backend
| if (typeof(options['searchParameters']) === 'function') { | ||
| return options['searchParameters'](term) |
There was a problem hiding this comment.
As we're not expecting any other type, should we drop the if condition?
There was a problem hiding this comment.
@RyanofWoods I'd love your opinion here, thoughts?
There was a problem hiding this comment.
Yes, it now makes sense to drop if (typeof(options['searchParameters']) === 'function') @kennyadsl, as if they pass a object, searchParameters should be mandatory. Please update the JSDocs as well -> * @param {Function} options.searchParameters. If they still haven't updated their deprecated code as well, it will be now more useful as it will break rather than silently do default behavior.
Note, this will mean stores cannot explicit pass in a empty object for default behavior, but they should have saw the deprecation for this, and they can just not pass any parameter for this behavior.
There was a problem hiding this comment.
One more note, this acts a little differently to productPicker, which defaults options to {} immediately, so we need this searchParameters check. Ideally they would have the same structure in the future 🤔
https://github.com/nebulab/solidus/blob/master/backend/app/assets/javascripts/spree/backend/product_picker.js
Instead, pass only
searchParameters: function (_selectSearchTerm) { return { suppliable_only: true } }
Ref solidusio#4767
Use Spree::LineItem#display_amount instead. Ref solidusio#4876
elia
force-pushed
the
kennyadsl/remove-deprecated-backend-3.x
branch
from
0d21f34
to
cc17289
Compare
This PR is part of 3.x Deprecations Removal.
Summary
This PR removes all the code deprecated in the Backend component. Please refer to each commit to better understand what has been removed and their replacements.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: