Split ruby and gems versions as a CI cache key #5005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the ruby version is way more integral to the installation and should not be conflated with gem versions that are easy to upgrade. The lack of this difference generated a situation in which a patch level ruby update ended up restoring a cache for the previous version.
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #5005 +/- ##
=======================================
Coverage 86.67% 86.67%
=======================================
Files 580 580
Lines 14727 14727
=======================================
Hits 12764 12764
Misses 1963 1963 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Forcing a merge to fix the CI |
elia
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since the ruby version is way more integral to the installation and should not be conflated with gem versions that are easy to upgrade.
The lack of this difference generated a situation in which a patch level ruby update ended up restoring a cache for the previous version.
E.G. see https://app.circleci.com/pipelines/github/solidusio/solidus/4199/workflows/81285fc7-0bc6-4709-9389-e60027f0d0c6/jobs/40237 on #4999
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: