Add Braintree to the installer as a payment method option #4961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
gsmendoza
force-pushed
the
gsmendoza/4749-braintree-payment-method
branch
from
123947d
to
e3f7cf1
Compare
gsmendoza
commented
Mar 3, 2023
gsmendoza
force-pushed
the
gsmendoza/4749-braintree-payment-method
branch
from
e3f7cf1
to
f274a66
Compare
gsmendoza
commented
Mar 3, 2023
| @@ -0,0 +1,5 @@ | |||
| unless Bundler.locked_gems.dependencies['solidus_braintree'] | |||
| bundle_command "add solidus_braintree --git='https://github.com/solidusio/solidus_braintree' --branch='master'" | |||
There was a problem hiding this comment.
The git and branch options are temporary. Once SolidusBraintree 3 is released, we can change this to "add solidus_braintree ~> 3.0"
There was a problem hiding this comment.
Thanks, @gsmendoza. Nice work. I left some suggestions. Also, holding approval until we release 2.0.
gsmendoza
force-pushed
the
gsmendoza/4749-braintree-payment-method
branch
from
f274a66
to
e4ed928
Compare
gsmendoza
commented
Mar 6, 2023
gsmendoza
commented
Mar 6, 2023
There was a problem hiding this comment.
Thanks, @gsmendoza! Everything looks fine. Holding approval until we release the new version of the gem.
kennyadsl
force-pushed
the
gsmendoza/4749-braintree-payment-method
branch
from
e4ed928
to
4df1ae7
Compare
kennyadsl
force-pushed
the
gsmendoza/4749-braintree-payment-method
branch
from
4df1ae7
to
3b9d196
Compare
elia
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
This was a much needed cleanup! 🙌
It should be applied equally to all enum options like payment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4749.
Blockers
This is dependent on releasing SolidusBraintree v3 (SolidusBraintree with StarterFrontend generator). See solidusio/solidus_braintree#94.
Code review feedback
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: