Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow bad payloads to be saved in payment log entries #4953

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Allow bad payloads to be saved in payment log entries #4953

merged 2 commits into from
Feb 24, 2023

Commits on Feb 23, 2023

  1. Share a superclass for the LogEntry serialization errors 

    Allow a rescue to catch both in one go
    @elia
    elia committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    df9ab52 View commit details
    Browse the repository at this point in the history

  2. Ensure we keep recording payment log entries that cannot be deserialized 

    Raising an exception at this time could prevent a payment from being
properly processed. Any incompatible response will be wrapped in a
valid one and saved with proper reporting.

This allows it to be both recorded and reported without breaking the
payment details page in the admin.
    @elia
    elia committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    a36e681 View commit details
    Browse the repository at this point in the history