Remove Slack notifications for CI failures #4928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waiting-for-dev
added
changelog:repository
waiting-for-dev
force-pushed
the
waiting-for-dev/remove_slack_notification
branch
from
dd238e7
to
9d82893
Compare
github-actions
bot
removed
the
changelog:repository
waiting-for-dev
force-pushed
the
waiting-for-dev/remove_slack_notification
branch
from
9d82893
to
16b10a5
Compare
We were storing the Slack secrets on a CircleCI context [1]. Although we were also passing them to forks [2], it resulted on unauthorized builds for external contributions. We could work around the issue in two ways: - Having the secrets outside of any context, but that would compromise the security of the associated Slack channel for: - Send messages as @circleci notifications - Send messages to channels @circleci notifications isn't a member of - Upload, edit, and delete files as CircleCI notifications - Using CircleCI logic statements [3] to conditionally run jobs when `CIRCLECI_USERNAME` or `CIRCLE_PR_USERNAME` env vars [4] are in a list of allowed users. However, that would be something difficult to maintain, and there's no other way to check the user's role. Given that we don't find those trade-offs to be acceptable, we remove the integration for now. [1] - https://circleci.com/docs/contexts/ [2] - https://circleci.com/docs/oss/#pass-secrets-to-builds-from-forked-pull-requests [3] - https://circleci.com/docs/configuration-reference/#logic-statements [4] - https://circleci.com/docs/variables/
waiting-for-dev
force-pushed
the
waiting-for-dev/remove_slack_notification
branch
from
16b10a5
to
07307ea
Compare
waiting-for-dev
added
the
changelog:repository
kennyadsl
approved these changes
Feb 9, 2023
|
@waiting-for-dev are we using the same approach on other repositories? |
waiting-for-dev
removed
backport-v3.2
backport-v3.3
elia
approved these changes
Feb 9, 2023
adammathys
approved these changes
Feb 9, 2023
Sure! I referenced all the similar PR on the original issue: #4902 (comment) |
waiting-for-dev
deleted the
waiting-for-dev/remove_slack_notification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were storing the Slack secrets on a CircleCI context. Although we were also passing them to forks, it resulted on unauthorized builds for external contributions.
We could work around the issue in two ways:
CIRCLECI_USERNAMEorCIRCLE_PR_USERNAMEenv vars are in a list of allowed users. However, that would be something difficult to maintain, and there's no other way to check the user's role.Given that we don't find those trade-offs to be acceptable, we remove the integration for now.
Closes #4902
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: