Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-add the default store to new payment methods #4828

Conversation

elia
Copy link
Member

@elia elia commented Jan 2, 2023

Summary

This is a sensible default that won't be to be touched most of the time. Previously it was required to be added manually.

image

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.

The following are not always needed (cross them out if they are not):

  • I have added automated tests to cover my changes.
- [ ] I have attached screenshots to demo visual changes. - [ ] I have opened a PR to update the [guides](https://github.com/solidusio/edgeguides). - [ ] I have updated the README to account for my changes.

@elia elia self-assigned this Jan 2, 2023
@github-actions github-actions bot added the changelog:solidus_backend Changes to the solidus_backend gem label Jan 2, 2023
This is a sensible default that won't be to be touched most of the
time. Previously it was required to be added manually.
@elia elia force-pushed the elia/set-default-store-for-new-payment-methods branch from 4ec1b0c to f9461a3 Compare January 2, 2023 11:05
@kennyadsl
Copy link
Member

@elia time to mark as ready?

@elia elia marked this pull request as ready for review January 5, 2023 13:09
@elia elia requested a review from a team as a code owner January 5, 2023 13:09
@elia
Copy link
Member Author

elia commented Jan 5, 2023

@elia time to mark as ready?

Yes! Done.

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennyadsl kennyadsl merged commit 16d1e37 into solidusio:master Jan 5, 2023
@kennyadsl kennyadsl deleted the elia/set-default-store-for-new-payment-methods branch January 5, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants