[v3.2] Merge pull request #4707 from cpfergus1/cpfergus1/fix-broken-image-upload-js #4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The was changed by mistake to `$.ajaxSetup.xhr()` and broke the image upload drop field. The error was missed because there were not any existing tests for the image drop field so the script was not being properly tested. Although `$.ajaxSetup().xhr()` could work in this situation, it will be fully reverted to original due to inability to find source of deprecation cited in commit that changed this function. (cherry picked from commit 58fcaae)
7 tasks
kennyadsl
approved these changes
Nov 9, 2022
kennyadsl
added
type:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mastertov3.2:Questions ?
Please refer to the Backport tool documentation