Fix Order#tax_address method #4429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarednorman
approved these changes
Jun 16, 2022
|
Hey @spaghetticode, if you rebase from master CI will be green 🪄 🙂 |
Calling `#tax_address` on an order that has no address but also no
store associates raises the following error:
undefined method `default_cart_tax_location' for nil:NilClass
Given that the `store` association is optional, and/or it may not
have been already set on the `Spree::Order` instance, we should
avoid raising an error.
A simple way to expose the issue is by entering the following
command in the Rails console:
Spree::Order.new.tax_address
spaghetticode
force-pushed
the
spaghetticode/fix-order-tax_address
branch
from
1cb99f6
to
f7f85bf
Compare
waiting-for-dev
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calling
#tax_addresson an order that has no address but also no store associated raises the following error:Given that the
storeassociation is optional, and/or it may not have been already set on theSpree::Orderinstance, we should avoid raising an error.A simple way to expose the issue is by entering the following command in the rails console:
Checklist: