Deprecate dangling option_values and duplicated routes #4385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes no sense to have dangling option_values without an associated option_type. Ref solidusio#3309 & solidusio#3517
|
I asked for some context here, #3517 (comment). It's quite old so not sure we can get anything but I thought it was worth trying. |
It looks like the referenced PR didn't introduce the behavior. It only added a test to make it explicit and fixed an issue when |
|
By the way, for some reason, CircleCI result is not being reported, although it was successful. See https://app.circleci.com/pipelines/github/nebulab/solidus?branch=waiting-for-dev%2Fduplicated_option_value_endpoints&filter=all |
aldesantis
approved these changes
May 26, 2022
kennyadsl
approved these changes
May 27, 2022
There's no need to fetch the parent id for those routes.
waiting-for-dev
force-pushed
the
waiting-for-dev/duplicated_option_value_endpoints
branch
from
d9583bf
to
7c49645
Compare
waiting-for-dev
deleted the
waiting-for-dev/duplicated_option_value_endpoints
branch
waiting-for-dev
added a commit
to nebulab/solidus
that referenced
this pull request
May 30, 2022
As in solidusio#4385: - We keep shallow member routes. We deprecate nested member routes. - We keep creation nested route. We deprecate creation shallow route. - We keep both shallow and nested collection routes (more flexibility for storefronts).
This was referenced May 30, 2022
cpfergus1
pushed a commit
to cpfergus1/solidus
that referenced
this pull request
Aug 25, 2022
As in solidusio#4385: - We keep shallow member routes. We deprecate nested member routes. - We keep creation nested route. We deprecate creation shallow route. - We keep both shallow and nested collection routes (more flexibility for storefronts).
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Mar 21, 2023
Add a NOT NULL validation at the database level on top of removing the existing deprecation warning. Ref solidusio#4385.
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Mar 21, 2023
Add a NOT NULL validation at the database level on top of removing the existing deprecation warning. Ref solidusio#4385.
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Mar 27, 2023
Add a NOT NULL validation at the database level on top of removing the existing deprecation warning. Ref solidusio#4385.
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 12, 2023
Add a NOT NULL validation at the database level on top of removing the existing deprecation warning. Ref solidusio#4385.
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 14, 2023
Add a NOT NULL validation at the database level on top of removing the existing deprecation warning. Ref solidusio#4385.
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 18, 2023
Add a NOT NULL validation at the database level on top of removing the existing deprecation warning. Ref solidusio#4385.
kennyadsl
added a commit
that referenced
this pull request
Apr 18, 2023
Add a NOT NULL validation at the database level on top of removing the existing deprecation warning. Ref #4385.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, we were allowing the creation of option_values without an associated option_type. It makes no sense from the domain logic perspective. Ref #3309 & #3517.
On top of that, we're deprecating the nested version for member routes, as there's no need to fetch the parent id for those.