Fix admin variants table UX #4322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The search field was visually pushed to the side, because the "with deleted" checkbox was not always visible.
jarednorman
approved these changes
Mar 30, 2022
|
Thanks @tvdeyen! In the After screenshot the error message doesn't look correct:
|
Ha, good eyes @kennyadsl! I made the screenshot before fixing it |
The "No search results" warning was never displayed, because the table was hidden if no variants were found. Also make the warning a warning and translate it properly.
tvdeyen
force-pushed
the
fix-admin-variants-table
branch
from
595c2f7
to
a2e563e
Compare
|
@kennyadsl fixed specs |
kennyadsl
approved these changes
Mar 31, 2022
spaghetticode
approved these changes
Mar 31, 2022
This was referenced Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The product variants table was lacking some UX. Please read commit messages for further details.
Before
After
Checklist: