Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update customizing-assets.html.md #4312

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Update customizing-assets.html.md #4312

merged 1 commit into from
Mar 28, 2022

Conversation

mapreal19
Copy link
Contributor

@mapreal19 mapreal19 commented Mar 22, 2022 •
edited
Loading

Updates docs on customizing assets:

Removes div from css selector. It's now a footer

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@mapreal19
Update customizing-assets.html.md
eff8543 
Removes `div` from css selector. It's now a `footer`
kennyadsl
kennyadsl approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

waiting-for-dev
waiting-for-dev approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@waiting-for-dev waiting-for-dev merged commit b3b16ce into solidusio:master Mar 28, 2022
@mapreal19 mapreal19 deleted the patch-1 branch March 28, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waiting-for-dev waiting-for-dev waiting-for-dev approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mapreal19 @waiting-for-dev @kennyadsl