Fix n+1 possibilities in Promotion#blacklisted? #4275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
fix-promotion-n+1
branch
2 times, most recently
from
510e3aa
to
b503abd
Compare
jarednorman
approved these changes
Feb 22, 2022
tvdeyen
reviewed
Feb 22, 2022
mamhoff
force-pushed
the
fix-promotion-n+1
branch
3 times, most recently
from
2d3a266
to
3da9069
Compare
The "blacklisted?" private method is called many times when recalculating an order with many line items. When preloading an order through ActiveRecord's `includes` or `preloads` feature, one will likely preload a product through the line item's variant. Thus it's preferable here to load the product through the variant.
When running this code, users have likely already loaded the line item's variant's products. There's no need to run this DB query.
mamhoff
force-pushed
the
fix-promotion-n+1
branch
from
3da9069
to
a934f63
Compare
|
Done 💦 |
tvdeyen
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes some n+1 possibilities in
Spree::Promotion#blacklisted?. First, we go through a line items' variant to get its product as that is more likely to be preloaded, and second, we useEnumerableto find out whether any line item's products are non-promotionable rather than issuing a DB query for every promotion / every line item when using an order-level promotion rule.Checklist: