Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add public interface to fetch registered events #4252

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Add public interface to fetch registered events #4252

merged 1 commit into from
Feb 3, 2022

Conversation

waiting-for-dev
Copy link
Contributor

Description

It adds value so that users don't need to scan source code or consult
external docs.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@waiting-for-dev
Add public interface to fetch registered events
98b8214 
It adds value so that users don't need to scan source code or consult
external docs.
forkata
forkata approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@forkata forkata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @waiting-for-dev, this looks great!

jarednorman
jarednorman approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like.

@waiting-for-dev waiting-for-dev merged commit 1ab4826 into solidusio:master Feb 3, 2022
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/event_names branch February 3, 2022 04:47
@waiting-for-dev waiting-for-dev mentioned this pull request Apr 15, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@jarednorman jarednorman jarednorman approved these changes

@gmacdougall gmacdougall gmacdougall approved these changes

@forkata forkata forkata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@waiting-for-dev @kennyadsl @jarednorman @gmacdougall @forkata