V2.11 - Fix non auto populated customer info

[nbelzer]

Resolves #3966

Description

• Includes a fix for Customer info are not auto-populated correctly in admin creating a new order #3966.
• Includes spec tests that verify the render behavior of the Backbone View Spree.Views.Order.Address.

The spec tests verify the behavior of the Address Backbone View based on two fixtures, these are extracts from the partial spree/admin/shared/address_form as I was unable to render the partial itself (due to the country and state fields). Because of this, the fixtures do not render the country and state fields, nor does the spec test verify that they are updated. Since this is unrelated to the original issue I don't think this is a problem for this PR.

It looks like this issue also exists on Solidus v3.x, so perhaps we should also merge these changes into the master branch? I would need some advice on how to do this correctly.

Checklist:

• I have followed Pull Request guidelines
• I have added a detailed description into each commit message
• I have updated Guides and README accordingly to this change (if needed)
• I have added tests to cover this change (if needed)
• I have attached screenshots to this PR for visual changes (if needed)

[kennyadsl]

@nbelzer thanks for this!!

3.x shouldn't have the use_combined_first_and_last_name_in_address preference. The default behavior from 3.0 is the same as having it true, but I didn't verify that this feature is working correctly on those versions. If you can check it would be awesome.

[nbelzer]

@kennyadsl You are correct, the preference does not exist on Spree::AppConfiguration (on Solidus 3.x) and the issue also doesn't appear as the field shown is Name which was already included in the Address Backbone view:

solidus/backend/app/assets/javascripts/spree/backend/views/order/address.js

Lines 24 to 32 in 7e0a386

	eachField: function(callback){
	var view = this;
	var fields = ["name", "company", "address1", "address2",
	"city", "zipcode", "phone", "country_id", "state_name"];
	_.each(fields, function(field) {
	var el = view.$('[name$="[' + field + ']"]');
	if (el.length) callback(field, el);
	});
	},

[kennyadsl]

Thanks @nbelzer!

[spaghetticode]

@nbelzer thank you!