Use SSL on fonts.googleapis.com scss import #4209
Conversation
|
I am not really sure why this line suddenly started causing issues. Would be interested to know if anyone has any insight. |
There was a problem hiding this comment.
Many thanks for looking into it @RyanofWoods! ❤️
I haven't found anything out there, but I guess that since that date, fonts.googleapis.com doesn't support non-SSL connections anymore. Anyway, it's good from our side to request through HTTPS.
I think we also need to update the URL here:
I'd also take the occasion to remove the duplication from this line:
solidus/backend/spec/spec_helper.rb
Line 100 in d4925d8
And instead require spree/testing_support/blacklsit_urls as is done from the frontend engine:
solidus/frontend/spec/spec_helper.rb
Line 39 in d4925d8
RyanofWoods
force-pushed
the
fix/frontend-scss-font-url-import
branch
from
1ddb10a
to
63abd1d
Compare
RyanofWoods
changed the title
Since 23/11/2021, `@import url(//fonts.googleapis.com/css...)` began to cause errors; Breaking Solidus and all extensions that depend on solidus_frontend. Explicitly using https protocol fixed this. Error example: https://app.circleci.com/pipelines/github/solidusio/solidus/2791/workflows/e62ff646-9ae6-4e65-b20f-e1f7a109d3a1/jobs/26572 Blocking of this URL in testing_support was updated to keep performance improvement.
RyanofWoods
force-pushed
the
fix/frontend-scss-font-url-import
branch
from
63abd1d
to
abd374e
Compare
Thank you for your help @waiting-for-dev! Amazing spot with the |
|
@RyanofWoods thanks! I think we need to release this in all the supported Solidus versions as well. Can you make the same PR against v3.1, v3.0 and v2.11, please? |
Done @kennyadsl 👍 Let me know if I could have done it in a more helpful way 🙂 |
Since 23/11/2021,
@import url(//fonts.googleapis.com/css...)began tocause errors; Breaking Solidus and all extensions that depend on
solidus_frontend. Explicitly using https protocol fixed this.
Error example:
https://app.circleci.com/pipelines/github/solidusio/solidus/2791/workflows/e62ff646-9ae6-4e65-b20f-e1f7a109d3a1/jobs/26572
Blocking of this URL in testing_support was updated to keep performance
improvement.
Checklist: