Remove the upgrade task and point to additional steps from the update generator #4157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, I'll do it right next 🙂 |
kennyadsl
approved these changes
Sep 6, 2021
… generator Having both an `upgrade` task and an `update` generator is confusing. On top of that, it's better to have actionable items, which can be undesirable in some situations, the most explicit as possible. For this reason, we leave in place the `update` generator, which is just a safe path to update preferences, and remove the `upgrade` task. Instead, we add a generic message into the `update` generator pointing to the detailed instructions in the Changelog. In particular, at this point, the `update` task was calling to a single task introduced in solidusio#3987. We still keep the task reachable by end-users, but we rename it slightly to be more friendly.
waiting-for-dev
force-pushed
the
waiting-for-dev/remove_upgrade_task
branch
from
a2e6ebe
to
516879a
Compare
5 tasks
kennyadsl
approved these changes
Sep 8, 2021
jarednorman
approved these changes
Sep 8, 2021
waiting-for-dev
added a commit
to nebulab/solidus
that referenced
this pull request
Sep 14, 2021
The old upgrade task was removed in solidusio#4157
5 tasks
kennyadsl
pushed a commit
that referenced
this pull request
Sep 20, 2021
The old upgrade task was removed in #4157
rmparr
pushed a commit
to rmparr/solidus
that referenced
this pull request
Jun 1, 2022
The old upgrade task was removed in solidusio#4157
rmparr
pushed a commit
to rmparr/solidus
that referenced
this pull request
Jun 1, 2022
The old upgrade task was removed in solidusio#4157
cpfergus1
pushed a commit
to cpfergus1/solidus
that referenced
this pull request
Aug 25, 2022
The old upgrade task was removed in solidusio#4157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Having both an
upgradetask and anupdategenerator is confusing. Ontop of that, it's better to have actionable items, which can be
undesirable in some situations, the most explicit as possible. For this
reason, we leave in place the
updategenerator, which is just a safepath to update preferences, and remove the
upgradetask. Instead, weadd a generic message into the
updategenerator pointing to thedetailed instructions in the Changelog.
In particular, at this point, the
updatetask was calling to a singletask introduced in #3987. We still keep the task reachable by end-users,
but we rename it slightly to be more friendly.
Checklist: