Hide the master variants from stock management #4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 26, 2021
| @@ -51,7 +51,10 @@ def load_stock_management_data | |||
|
|
|||
| def variant_scope | |||
| scope = Spree::Variant.accessible_by(current_ability) | |||
| scope = scope.where(product: @product) if @product | |||
| if @product do | |||
jarednorman
requested changes
Aug 26, 2021
Comment on lines
51
to
56
| expect(assigns(:variants)).not_to include variant_1 | ||
| expect(assigns(:variants)).not_to include variant_2 | ||
| expect(assigns(:variants)).to include product_1.master | ||
| expect(assigns(:variants)).not_to include product_2.master | ||
| expect(assigns(:variants)).not_to include variant_3 | ||
| expect(assigns(:variants)).not_to include variant_4 |
There was a problem hiding this comment.
These are pretty verbose, could use the contain_exactly to make them a little more terse:
Suggested change
| expect(assigns(:variants)).not_to include variant_1 | |
| expect(assigns(:variants)).not_to include variant_2 | |
| expect(assigns(:variants)).to include product_1.master | |
| expect(assigns(:variants)).not_to include product_2.master | |
| expect(assigns(:variants)).not_to include variant_3 | |
| expect(assigns(:variants)).not_to include variant_4 | |
| expect(assigns(:variants)).to contain_exactly(product_1.master) |
Comment on lines
61
to
66
| expect(assigns(:variants)).not_to include variant_1 | ||
| expect(assigns(:variants)).not_to include variant_2 | ||
| expect(assigns(:variants)).not_to include product_1.master | ||
| expect(assigns(:variants)).not_to include product_2.master | ||
| expect(assigns(:variants)).to include variant_3 | ||
| expect(assigns(:variants)).to include variant_4 |
There was a problem hiding this comment.
Similarly:
Suggested change
| expect(assigns(:variants)).not_to include variant_1 | |
| expect(assigns(:variants)).not_to include variant_2 | |
| expect(assigns(:variants)).not_to include product_1.master | |
| expect(assigns(:variants)).not_to include product_2.master | |
| expect(assigns(:variants)).to include variant_3 | |
| expect(assigns(:variants)).to include variant_4 | |
| expect(assigns(:variants)).to contain_exactly(variant_3, variant_4) |
Comment on lines
73
to
78
| expect(assigns(:variants)).to include variant_1 | ||
| expect(assigns(:variants)).to include variant_2 | ||
| expect(assigns(:variants)).to include product_1.master | ||
| expect(assigns(:variants)).to include product_2.master | ||
| expect(assigns(:variants)).to include variant_3 | ||
| expect(assigns(:variants)).to include variant_4 |
There was a problem hiding this comment.
And:
Suggested change
| expect(assigns(:variants)).to include variant_1 | |
| expect(assigns(:variants)).to include variant_2 | |
| expect(assigns(:variants)).to include product_1.master | |
| expect(assigns(:variants)).to include product_2.master | |
| expect(assigns(:variants)).to include variant_3 | |
| expect(assigns(:variants)).to include variant_4 | |
| expect(assigns(:variants)).to contain_exactly( | |
| variant_1, | |
| variant_2, | |
| product_1.master, | |
| product_2.master, | |
| variant_3, | |
| variant_4 | |
| ) |
|
Good suggestion - thanks! Updated to be a little more terse. |
jarednorman
requested changes
Aug 27, 2021
Comment on lines
55
to
56
| scope = scope.where(product: @product) | ||
| scope = scope.where(is_master: [email protected]_variants?) |
There was a problem hiding this comment.
You can do this as one call:
Suggested change
| scope = scope.where(product: @product) | |
| scope = scope.where(is_master: !@product.has_variants?) | |
| scope = scope.where( | |
| product: @product, | |
| is_master: !@product.has_variants? | |
| ) |
This PR hides the master variants from the stock management list if the product has variants. This prevents a strange experience when managing inventory for these products - they don't really have SKUs, and aren't sellable in the general case.
tmtrademarked
force-pushed
the
hide_master_from_stock
branch
from
1edbd8a
to
9cf55e5
Compare
|
Updated and squashed! Let me know if you'd prefer a different format in the message/etc. Thanks, Jared! |
jarednorman
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hides the master variants from the stock management list if the product has variants. This prevents a strange experience when managing inventory for these products - they don't really have SKUs, and aren't sellable in the general case.
Before:
After:
