Fix Ransack error when searching for orders by customer name #4135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's an issue in 3.0 where, if you try to search for an order by the customer's name, Ransack crashes. The problem was introduced inadvertently in 94bfaa7[1]. This Ransackable attribute was supposed to be removed completely, since it is not a Ransack alias anymore, but an actual DB column that lives on the `bill_address` association. [1]: solidusio@94bfaa7
jarednorman
approved these changes
Jul 27, 2021
|
@solidusio/core-team can I get one more review on this? 🙏 |
|
This is missing in v3.0 and broken since. I will provide a backporting PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue in 3.0 where, if you try to search for an order by the customer's name, Ransack crashes.
The problem was introduced inadvertently in 94bfaa7. This Ransackable attribute was supposed to be removed completely, since it is not a Ransack alias anymore, but an actual DB column that lives on the
bill_addressassociation.A regression test didn't seem necessary, given the minor nature of the problem.
Checklist: