Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guides typo corrections #4120

Merged
merged 4 commits into from
Aug 2, 2021
Merged

Guides typo corrections #4120

merged 4 commits into from
Aug 2, 2021

Conversation

cesartalves
Copy link
Contributor

@cesartalves cesartalves commented Jun 25, 2021 •
edited
Loading

Description
Several English / typo corrections on the Guides I was able to find on the past weeks.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

kennyadsl
kennyadsl approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cesar!

@cesartalves
Copy link
Contributor Author

Thanks Cesar!

I'm going through the entire Solidus Docs, so I might find a few extra corrections to add to the PR this week 🙃

@cesartalves cesartalves force-pushed the general-doc-typo-corrections branch from 8d757c3 to 54037ef Compare July 8, 2021 18:10
@cesartalves cesartalves marked this pull request as ready for review July 23, 2021 13:05
spaghetticode
spaghetticode approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cesartalves thank you 👍

@kennyadsl kennyadsl merged commit a2310fe into solidusio:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaghetticode spaghetticode spaghetticode approved these changes

@jarednorman jarednorman jarednorman approved these changes

@kennyadsl kennyadsl Awaiting requested review from kennyadsl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cesartalves @spaghetticode @kennyadsl @jarednorman