Update defaults in dummy application #4047
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here it's a description of the reason for each change. Keep in mind that
CI test against Rails 5.2 as the minimal version:
serve_static_assets: Removed it. It's not available since Rails
5.0.
public_file_server.enabled: Set explicitly to
true
. Even if it wasalready
true
, a real Rails application will default it tofalse
inthe production environment unless a env variable
RAILS_SERVE_STATIC_FILES
ispresent. This way it's less surprising.
whiny_nils: Removed. It's not available since Rails
4.1.
action_controller.allow_forgery_protection: Set to true to mimic
production.
action_controller.default_protect_from_forgery: Set to true to mimic
production.
action_controller.perform_caching: Set to true to mimic production.
active_support.deprecation: Remove duplicated entry.
action_mailer.delivery_job: Removed because
load_defaults
take care ofit.
storage_path: Removed. It wasn't a Rails setting, but used as a
convenience. It was confusing.
action_controller.include_all_helpers: Removed as it's already the
default.
log_level: Added. It already defaulted to
:debug
, but a real Rails appwill default to
:info
in production. To make things less surprisinglet's be explicit.
action_mailer.perform_caching: Added to mimic production.
i18n.fallbacks: Added to mimic production.
active_record.dump_schema_after_migration: Added to mimic production and
for better performance.
assets: No need to check whether it's a method on
config
.See #4035
Checklist: