Relax Money dependency in development #3958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CHF currency issue we were having has been fixed and a new version (1.14.1) has been released.
kennyadsl
added
changelog:solidus_core
|
Maybe not necessary, but should we consider locking it to not the versions we know don't work? |
|
I'd avoid that Jared, it's a patch-level fix so it's very unlikely that people have Money locked at that specific version. Or are you thinking at a specific scenario where this could cause issues? |
|
Nah, if it's just one patch release that's affected then I agree, let's not worry about it. |
aldesantis
approved these changes
Feb 26, 2021
jarednorman
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref #3903
The CHF currency issue we were having has been fixed and a new version (1.14.1) that contains the fix has been released. CI should be green now.
We can backport this commit to v2.11 when merged.
Checklist:
[ ] I have updated Guides and README accordingly to this change (if needed)[ ] I have added tests to cover this change (if needed)[ ] I have attached screenshots to this PR for visual changes (if needed)