Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show 'guest' correctly in order customer details #3910

Merged
merged 1 commit into from
Jan 28, 2021
Merged

Show 'guest' correctly in order customer details #3910

merged 1 commit into from
Jan 28, 2021

Conversation

nirebu
Copy link
Contributor

@nirebu nirebu commented Jan 25, 2021

Description

There is a small visual bug in the admin_order_customerpath, where the UI shows the order as a guest order if there was a user associated to it, and vice-versa.

This PR fixes that.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

kennyadsl
kennyadsl approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spaghetticode
spaghetticode approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirebu thanks!

@kennyadsl kennyadsl added this to the 2.11 milestone Jan 28, 2021
@kennyadsl
Copy link
Member

Merging since the only failing spec is related to another issue already addressed.

@kennyadsl kennyadsl merged commit 425d590 into solidusio:master Jan 28, 2021
@kennyadsl kennyadsl added the changelog:solidus_backend Changes to the solidus_backend gem label Jan 28, 2021
@nirebu nirebu deleted the nirebu/fix-guest-checkout-label-in-customer-details branch January 29, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaghetticode spaghetticode spaghetticode approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nirebu @kennyadsl @spaghetticode