Rename all occurrences of emails with spree username to solidus #3849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 23, 2020
|
After my initial commit, I noticed this: Then I also renamed all occurrences of |
rubenochiavone
force-pushed
the
rename_emails_with_spree_username
branch
from
e04693f
to
ccb3c29
Compare
houndci-bot
reviewed
Nov 23, 2020
rubenochiavone
force-pushed
the
rename_emails_with_spree_username
branch
from
ccb3c29
to
4c61792
Compare
jarednorman
approved these changes
Nov 25, 2020
Sinetheta
added a commit
to Sinetheta/solidus_graphql_api
that referenced
this pull request
Dec 14, 2020
The store factory was updated in solidusio/solidus#3849 If Solidus is now embracing this kind of churn we may not want to assert directly against it's testing helpers.
Sinetheta
added a commit
to Sinetheta/solidus_graphql_api
that referenced
this pull request
Dec 14, 2020
The store factory was updated in solidusio/solidus#3849 Although I see the "with_args" helper is being used elsewhere to allow for asserting against dynamic payloads, the only reason this value is changing on us is because of the unspoken dependency on the attributes in a solidus factory. If Solidus is going to embrace this kind of churn then we'd probably be best to set all relevant attributes explicitly. e Please enter the commit message for your changes. Lines starting
Sinetheta
added a commit
to Sinetheta/solidus_graphql_api
that referenced
this pull request
Dec 14, 2020
The store factory was updated in solidusio/solidus#3849 Although I see the "with_args" helper is being used elsewhere to allow for asserting against dynamic payloads, the only reason this value is changing on us is because of the unspoken dependency on the attributes in a solidus factory. If Solidus is going to embrace this kind of churn then we'd probably be best to set all relevant attributes explicitly. e Please enter the commit message for your changes. Lines starting
Sinetheta
added a commit
to Sinetheta/solidus_graphql_api
that referenced
this pull request
Dec 14, 2020
The store factory was updated in solidusio/solidus#3849 Although I see the "with_args" helper is being used elsewhere to allow for asserting against dynamic payloads, the only reason this value is changing on us is because of the unspoken dependency on the attributes in a solidus factory. If Solidus is going to embrace this kind of churn then we'd probably be best to set all relevant attributes explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a search and replace using regex
spree@((?:[a-z0-9](?:[a-z0-9-]{0,61}[a-z0-9])?\.)+[a-z0-9][a-z0-9-]{0,61}[a-z0-9])and replaced it withsolidus@$1. After that, I ran the specs to check if they were passing.Fixes #3829.
Checklist: