Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the singular translation for Spree::Role #3799

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Fix the singular translation for Spree::Role #3799

merged 1 commit into from
Oct 15, 2020

Conversation

elia
Copy link
Member

@elia elia commented Oct 14, 2020 •
edited
Loading

Description

Surely just a typo (git blame didn't bring up any good reason).

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@elia elia marked this pull request as ready for review October 14, 2020 09:59
spaghetticode
spaghetticode approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elia thank you!

@kennyadsl kennyadsl merged commit 130fcf2 into solidusio:master Oct 15, 2020
@kennyadsl kennyadsl deleted the elia/fix-role-model-singular-translation branch October 15, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaghetticode spaghetticode spaghetticode approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elia @spaghetticode @kennyadsl