Add CSS selector for datetime-local #3792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldesantis
approved these changes
Oct 8, 2020
|
I think that makes sense, thanks @jacobherrington! |
jarednorman
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relevant: https://apidock.com/rails/v6.0.0/ActionView/Helpers/FormHelper/datetime_field
You could argue that because we don't use this method in the vanilla backend, it doesn't need to be in the CSS, but I don't see any harm in adding it. 🙂
Closes #3755
Checklist:
- [ ] I have added tests to cover this change (if needed)- [ ] I have attached screenshots to this PR for visual changes (if needed)