Remove CanCanCan custom actions aliases (cont.) #3701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a continuation of #3148
Current Solidus' CanCanCan custom action aliases are not needed anymore and can make maintaining permissions and upgrading to new versions of CanCanCan much harder.
This PR:
The new
use_custom_cancancan_actions
preference can be set tofalse
to ignore legacy custom aliases and to apply CanCanCan default aliases.If
use_custom_cancancan_actions
is set totrue
(default value for existing stores)::read
alias is used since its behavior had been customized (:show, :to => :read
) and it's different from default CanCanCan behavior (index, :show, :to => :read
).Checklist:
[ ] I have updated Guides and README accordingly to this change (if needed)[ ] I have added tests to cover this change (if needed)[ ] I have attached screenshots to this PR for visual changes (if needed)