Do not attempt to create multiple records with global_zone factory
#3688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarednorman
approved these changes
Jul 2, 2020
|
How about this? factory :global_zone do
initialize_with { Spree::Zone.find_or_initialize_by(name: name) }
# ...
end |
|
@aldesantis thank you, that's exactly what I was looking for but somehow I was not able to find it... this seems to be such a better solution. I'm updating the PR. |
5ec5f36
to
4f41416
Compare
The factory linting spec is breaking many PR builds lately with
this error:
FactoryBot::InvalidFactoryError:
The following factories are invalid:
* global_zone - Validation failed: Name has already been taken
(ActiveRecord::RecordInvalid)
The problem is likely caused by the fact that the factory `global_zone`
can be used only once, as the name is fixed to "Global Zone" and the
model has a uniqueness validation on `name`. Still, I don't really
understand why the problem happens, as the DB should be clean when this
spec example is run.
Anyway, the factory now uses the `initialize_with` strategy in order to
avoid creating invalid records when the global zone already exists.
4f41416
to
34ca4fd
Compare
global_zone factoryglobal_zone factory
jarednorman
approved these changes
Jul 6, 2020
aldesantis
approved these changes
Jul 6, 2020
|
ah! I had to do the same in this commit: 3180cbf Will rebase from master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The factory linting spec is breaking many PR builds lately with this error:
I think this has something to do with the fact that the factory
global_zonecan be used only once, as the name is fixed to "Global Zone" and the model has a uniqueness validation onname. Still, I don't really understand why the problem happens, as the DB should be clean when this spec example is run.Checklist: