Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable/Disable store credit at checkout step #3661

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Enable/Disable store credit at checkout step #3661

wants to merge 1 commit into from
+40 −3

Conversation

DanielePalombo
Copy link
Contributor

Description
This PR adds the ability for the user to enable/disable the store credits at checkout step

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@DanielePalombo DanielePalombo force-pushed the nebulab/selectable-store-credits branch from 2232dbb to 8e3b990 Compare June 12, 2020 16:23
@DanielePalombo DanielePalombo force-pushed the nebulab/selectable-store-credits branch from 8e3b990 to b040a9c Compare June 19, 2020 08:47
@waiting-for-dev
Copy link
Contributor

Hey @DanielePalombo, would you still like to add this feature on solidus?

@waiting-for-dev
Copy link
Contributor

I'll closing it now, but if you find the time to keep working on it, I'll happily reopen 🙂

@DanielePalombo
Copy link
Contributor Author

Hi @waiting-for-dev ,
Sorry, I didn't answer you previously. I would like to work on it, but I have the time.

@waiting-for-dev
Copy link
Contributor

No worries @DanielePalombo, reopening 🙂

@kennyadsl kennyadsl added the type:enhancement Proposed or newly added feature label Aug 24, 2022
@waiting-for-dev waiting-for-dev added the changelog:solidus_core Changes to the solidus_core gem label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
changelog:solidus_core Changes to the solidus_core gem type:enhancement Proposed or newly added feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanielePalombo @waiting-for-dev @houndci-bot @kennyadsl