Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BCC email to spree_store #3646

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Conversation

seand7565
Copy link
Contributor

@seand7565 seand7565 commented May 30, 2020

THIS PR SPONSORED BY Super Good Software

Description
Adds a BCC email field to the spree store edit page.
This indicates a BCC email that you want all order confirmation
emails to be BCCed to. As indicated in #3615 , this is a feature
that I think a lot of eCommerce stores are interested in, at
the very least to server as a notification of a new order.

image

Also adds the ability to add/update this field through the API

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seand7565 thanks for adding this new feature, I think it's going to be useful to many stores 👍

nitpick: I noticed that in the screenshot the label BCC email is not capitalized like the others, maybe that needs to be done with CSS?

api/spec/requests/spree/api/stores_controller_spec.rb Outdated Show resolved Hide resolved
Adds a BCC email field to the spree store edit page.
This indicates a BCC email that you want all order confirmation
emails to be BCCed to. As indicated in solidusio#3615, this is a feature
that I think a lot of eCommerce stores are interested in, at
the very least to server as a notification of a new order.

Also adds the ability to add/update this field through the API
@peterberkenbosch
Copy link
Contributor

awesome! Thanks Sean. I think we had this present in the past as well, not sure why it got removed then, but this is super useful!

Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peterberkenbosch for asking the question I was about to. 😂

Looks good to me.

@aldesantis
Copy link
Member

Thanks @seand7565!

@afdev82
Copy link
Contributor

afdev82 commented Oct 16, 2020

I already had a PR for that feature, but it was refused because it was not enough general/flexible: #2905
I'm glad that now it's finally landed in the core and I can again use the upstream version of Solidus! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants